Replace getByBlockNumber by getByBlockHeader #5020

gfukushima · 2023-01-30T06:56:42Z

PR description

First batch that replaces getByBlockNumber by getByBlockHeader. These batch includes trivial replacements with none or minimal changes to the logic of the code base.

Fixed Issue(s)

Documentation

I thought about documentation and added the doc-change-required label to this PR if
updates are required.

Changelog

I thought about the changelog and included a changelog update if required.

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

macfarla

LGTM. couple of comments

...merge/src/test/java/org/hyperledger/besu/consensus/merge/TransitionProtocolScheduleTest.java

...m/api/src/main/java/org/hyperledger/besu/ethereum/api/jsonrpc/internal/DebugReplayBlock.java

.../src/test/java/org/hyperledger/besu/ethereum/eth/sync/fastsync/FastImportBlocksStepTest.java

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/query/BlockchainQueries.java

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

siladu

LGTM

This reverts commit 9ceebc4.

This reverts commit 9ceebc4. Signed-off-by: Jason Frame <jason.frame@consensys.net>

* Replace getByBlockNumber by getByBlockHeader where trivial Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Fix tests Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Fix tests Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Rolledback change since tests will need non trivial changes Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Rollback replace Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Change other 2 trivial tests Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * spotless Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Pass ProcessableBlockHeader to the mocks Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Replace getByBlockNumber by getByBlockHeader Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add mock of blockHeader Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Use any() for the tests Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add unit test for headBlockHeader() Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> --------- Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>

siladu · 2023-02-08T05:29:57Z

Bug found during goerli sync: #5064

* Replace getByBlockNumber by getByBlockHeader where trivial Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Fix tests Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Fix tests Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Rolledback change since tests will need non trivial changes Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Rollback replace Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Change other 2 trivial tests Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * spotless Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Pass ProcessableBlockHeader to the mocks Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Replace getByBlockNumber by getByBlockHeader Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add mock of blockHeader Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Use any() for the tests Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add unit test for headBlockHeader() Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> --------- Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>

…" (hyperledger#5063) This reverts commit 9ceebc4. Signed-off-by: Jason Frame <jason.frame@consensys.net>

* Replace getByBlockNumber by getByBlockHeader where trivial Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Fix tests Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Fix tests Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Rolledback change since tests will need non trivial changes Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Rollback replace Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Change other 2 trivial tests Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * spotless Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Pass ProcessableBlockHeader to the mocks Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Replace getByBlockNumber by getByBlockHeader Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add mock of blockHeader Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Use any() for the tests Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add unit test for headBlockHeader() Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> --------- Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>

…" (hyperledger#5063) This reverts commit 9ceebc4. Signed-off-by: Jason Frame <jason.frame@consensys.net>

* Replace getByBlockNumber by getByBlockHeader where trivial Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Fix tests Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Fix tests Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Rolledback change since tests will need non trivial changes Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Rollback replace Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Change other 2 trivial tests Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * spotless Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Pass ProcessableBlockHeader to the mocks Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Replace getByBlockNumber by getByBlockHeader Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add mock of blockHeader Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Use any() for the tests Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * Add unit test for headBlockHeader() Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> --------- Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>

…" (hyperledger#5063) This reverts commit 9ceebc4. Signed-off-by: Jason Frame <jason.frame@consensys.net>

gfukushima added 8 commits January 25, 2023 17:39

Replace getByBlockNumber by getByBlockHeader where trivial

9181f3b

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Fix tests

d0d8c3e

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Fix tests

47794d8

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Rolledback change since tests will need non trivial changes

508885a

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Rollback replace

01bac49

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Merge branch 'main' into replace-getByBlockNumber-by-getByBlockHeader

e74025c

Change other 2 trivial tests

eca7596

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

spotless

8d9c0d8

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

gfukushima marked this pull request as ready for review January 31, 2023 22:45

macfarla approved these changes Feb 1, 2023

View reviewed changes

gfukushima added 6 commits February 1, 2023 16:42

Pass ProcessableBlockHeader to the mocks

b5559b9

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Replace getByBlockNumber by getByBlockHeader

0239537

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Merge branch 'main' into replace-getByBlockNumber-by-getByBlockHeader

d223aae

Add mock of blockHeader

be677b1

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Use any() for the tests

7cfd093

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

Merge branch 'main' into replace-getByBlockNumber-by-getByBlockHeader

479e51a

jframe reviewed Feb 2, 2023

View reviewed changes

ethereum/api/src/main/java/org/hyperledger/besu/ethereum/api/query/BlockchainQueries.java Show resolved Hide resolved

Add unit test for headBlockHeader()

4bba346

Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>

jframe approved these changes Feb 2, 2023

View reviewed changes

siladu approved these changes Feb 2, 2023

View reviewed changes

gfukushima and others added 3 commits February 3, 2023 10:58

Merge branch 'main' into replace-getByBlockNumber-by-getByBlockHeader

be34ecd

Merge branch 'main' into replace-getByBlockNumber-by-getByBlockHeader

87d1633

Merge branch 'main' into replace-getByBlockNumber-by-getByBlockHeader

7f823d6

gfukushima enabled auto-merge (squash) February 5, 2023 10:27

gfukushima added TeamGroot GH issues worked on by Groot Team mainnet EIP Ethereum Improvement Proposal labels Feb 5, 2023

gfukushima disabled auto-merge February 5, 2023 10:31

gfukushima changed the title ~~Replace get by block number by get by block header~~ Replace getByBlockNumber by getByBlockHeader Feb 5, 2023

gfukushima merged commit 9ceebc4 into hyperledger:main Feb 5, 2023

jframe added a commit to jframe/besu that referenced this pull request Feb 8, 2023

Revert "Replace getByBlockNumber by getByBlockHeader (hyperledger#5020)"

30472eb

This reverts commit 9ceebc4.

jframe added a commit to jframe/besu that referenced this pull request Feb 8, 2023

Revert "Replace getByBlockNumber by getByBlockHeader (hyperledger#5020)"

7831830

This reverts commit 9ceebc4. Signed-off-by: Jason Frame <jason.frame@consensys.net>

jframe mentioned this pull request Feb 8, 2023

Revert "Replace getByBlockNumber by getByBlockHeader (#5020)" #5063

Merged

3 tasks

jframe added a commit that referenced this pull request Feb 8, 2023

Revert "Replace getByBlockNumber by getByBlockHeader (#5020)" (#5063)

38d666d

This reverts commit 9ceebc4. Signed-off-by: Jason Frame <jason.frame@consensys.net>

ensi321 pushed a commit to ensi321/besu that referenced this pull request Feb 19, 2023

Revert "Replace getByBlockNumber by getByBlockHeader (hyperledger#5020)…

bfe690e

…" (hyperledger#5063) This reverts commit 9ceebc4. Signed-off-by: Jason Frame <jason.frame@consensys.net>

gfukushima mentioned this pull request Feb 23, 2023

Replace getByBlockNumber by getByBlockHeader #5127

Merged

7 tasks

elenduuche pushed a commit to elenduuche/besu that referenced this pull request Aug 16, 2023

Revert "Replace getByBlockNumber by getByBlockHeader (hyperledger#5020)…

da4bb76

…" (hyperledger#5063) This reverts commit 9ceebc4. Signed-off-by: Jason Frame <jason.frame@consensys.net>

eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023

Revert "Replace getByBlockNumber by getByBlockHeader (hyperledger#5020)…

79bda73

…" (hyperledger#5063) This reverts commit 9ceebc4. Signed-off-by: Jason Frame <jason.frame@consensys.net>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace getByBlockNumber by getByBlockHeader #5020

Replace getByBlockNumber by getByBlockHeader #5020

gfukushima commented Jan 30, 2023 •

edited

Loading

macfarla left a comment

siladu left a comment

siladu commented Feb 8, 2023

Replace getByBlockNumber by getByBlockHeader #5020

Replace getByBlockNumber by getByBlockHeader #5020

Conversation

gfukushima commented Jan 30, 2023 • edited Loading

PR description

Fixed Issue(s)

Documentation

Changelog

macfarla left a comment

Choose a reason for hiding this comment

siladu left a comment

Choose a reason for hiding this comment

siladu commented Feb 8, 2023

gfukushima commented Jan 30, 2023 •

edited

Loading