Fix: Hive engine api FCU regression #4947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… before head timestamp Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
jframe
reviewed
Jan 18, 2023
| @@ -143,6 +143,10 @@ public JsonRpcResponse syncResponse(final JsonRpcRequestContext requestContext) | |||
| ws -> | |||
| ws.stream().map(WithdrawalParameter::toWithdrawal).collect(toList()))); | |||
|
|
|||
| ForkchoiceResult result = | |||
There was a problem hiding this comment.
Can we add this case to unit test as well
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
* Swap lines order to ensure we commit FCU even if payload timestamp is before head timestamp Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * spotless Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* Swap lines order to ensure we commit FCU even if payload timestamp is before head timestamp Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> * spotless Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com> Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swap lines order to ensure we commit FCU even if payload timestamp is before head timestamp
Signed-off-by: Gabriel Fukushima gabrielfukushima@gmail.com
PR description
This PR fixes the regression introduced recently.
Fixed Issue(s)
Makes Besu compliant with ForkChoiceUpdate_V1 - item 7 of the Engine API specs for Paris. (https://github.com/ethereum/execution-apis/blob/main/src/engine/paris.md)
Linked to #4747
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog