EIP-3860 Initcode Size Reference Test fixes #4911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix corner cases around initcode size checking in reference tests. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
siladu
reviewed
Jan 12, 2023
evm/src/main/java/org/hyperledger/besu/evm/operation/AbstractCreateOperation.java
Show resolved
Hide resolved
...um/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetTransactionValidator.java
Outdated
Show resolved
Hide resolved
evm/src/main/java/org/hyperledger/besu/evm/operation/CreateOperation.java
Show resolved
Hide resolved
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
siladu
approved these changes
Jan 12, 2023
evm/src/test/java/org/hyperledger/besu/evm/operations/Create2OperationTest.java
Outdated
Show resolved
Hide resolved
…perationTest.java Co-authored-by: Simon Dudley <simon.l.dudley@hotmail.com> Signed-off-by: Danno Ferrin <danno.ferrin@shemnon.com>
siladu
reviewed
Jan 14, 2023
| TransactionType.ACCESS_LIST, | ||
| TransactionType.EIP1559), | ||
| quorumCompatibilityMode, | ||
| SHANGHAI_INIT_CODE_SIZE_LIMIT)) |
There was a problem hiding this comment.
@shemnon I just spotted this...should it be
configContractSizeLimit.orElse(SHANGHAI_INIT_CODE_SIZE_LIMIT)?
There was a problem hiding this comment.
No. We are limiting initcocde, Which is twice the contract size limit. initcode and contract code have two different limits.
siladu
pushed a commit
to siladu/besu
that referenced
this pull request
Jan 14, 2023
* EIP-3860 Initcode Size Reference Test fixes Fix corner cases around initcode size checking in reference tests. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
2 tasks
elenduuche
pushed a commit
to elenduuche/besu
that referenced
this pull request
Aug 16, 2023
* EIP-3860 Initcode Size Reference Test fixes Fix corner cases around initcode size checking in reference tests. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* EIP-3860 Initcode Size Reference Test fixes Fix corner cases around initcode size checking in reference tests. Signed-off-by: Danno Ferrin <danno.ferrin@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fix corner cases around initcode size checking in reference tests.
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog