Optimize Sstore operation execution time #4836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…once. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
ahamlat
changed the title
…forks) Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
evm/src/main/java/org/hyperledger/besu/evm/gascalculator/GasCalculator.java
Fixed
Show fixed
Hide fixed
evm/src/main/java/org/hyperledger/besu/evm/gascalculator/GasCalculator.java
Fixed
Show fixed
Hide fixed
evm/src/main/java/org/hyperledger/besu/evm/gascalculator/GasCalculator.java
Fixed
Show fixed
Hide fixed
evm/src/main/java/org/hyperledger/besu/evm/gascalculator/GasCalculator.java
Fixed
Show fixed
Hide fixed
shemnon
suggested changes
Dec 20, 2022
There was a problem hiding this comment.
The CodeQL warnings all appear legitimage, so please address them.
As this is changing an API on an interface it will be a breaking change and will need to land in 23.1.0-beta and not be cherry picked into 22.10.4.
Also, add a changelog entry under breaking changes.
garyschulte
approved these changes
Dec 22, 2022
evm/src/main/java/org/hyperledger/besu/evm/gascalculator/LondonGasCalculator.java
Outdated
Show resolved
Hide resolved
evm/src/main/java/org/hyperledger/besu/evm/gascalculator/IstanbulGasCalculator.java
Outdated
Show resolved
Hide resolved
…HANGELOG.md Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
shemnon
approved these changes
Dec 22, 2022
Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
macfarla
pushed a commit
to macfarla/besu
that referenced
this pull request
Jan 10, 2023
* Optimize Sstore operation, get current value and original value only once. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> * Fix javadoc. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> * refactoring (add a supplier implementation to better support all the forks) Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> * delete unnecessary parameters, add final for some fields and modify CHANGELOG.md Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> * add a missing parameter in Javadoc Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* Optimize Sstore operation, get current value and original value only once. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> * Fix javadoc. Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> * refactoring (add a supplier implementation to better support all the forks) Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> * delete unnecessary parameters, add final for some fields and modify CHANGELOG.md Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> * add a missing parameter in Javadoc Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ameziane H ameziane.hamlat@consensys.net
PR description
This PR aims to improve SStore operation execution time by getting the original value and current value only once during gas cost and refund calculation. Currently, we make these two calls twice, and even with RocksDB cache, this has an impact on SStore performance as we can see in the CPU profiling flame graph below.
After this PR, we can see that getSorageValue (get current value) and getOriginalStorageValue are called only once.
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog