Use safe block as pivot block during snapsync #4819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matkt
changed the title
fab-10
approved these changes
Dec 14, 2022
matkt
force-pushed
the
feature/use-safe-block-for-pivot-block
branch
2 times, most recently
from
6ce8c84 to
4f9906c
Compare
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
matkt
force-pushed
the
feature/use-safe-block-for-pivot-block
branch
from
4f9906c to
ddf5aa8
Compare
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Dec 22, 2022
Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
macfarla
added a commit
to jflo/besu
that referenced
this pull request
Jan 10, 2023
Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Jan 14, 2023
Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Jan 14, 2023
Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
2 tasks
garyschulte
pushed a commit
to garyschulte/besu
that referenced
this pull request
Jan 14, 2023
Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
added a commit
that referenced
this pull request
Jan 14, 2023
* Use safe block as pivot block suring snapsync (#4819) * Bugfix snapshot transaction segfaults after storage truncation (#4786) * Bugfix potential chain head and worldstate inconsistency (#4862) * Peering - disconnect worst peer (#4888) * Attempt to fix CPU spikes issue (#4867) * not block subscribe when the worldstate storage is open (#4912) Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: garyschulte <garyschulte@gmail.com> Signed-off-by: Ameziane H <ameziane.hamlat@consensys.net> Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
fab-10
pushed a commit
to fab-10/besu
that referenced
this pull request
Jan 18, 2023
Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karim TAAM karim.t2am@gmail.com
PR description
I found that if we only use finalized block during snapsync is not a good choice because we will have 60 blocks windows to download and heal. It can impact the performance of the sync because we will not have enough time to download a lof of leafs and heal etc. I found
A finalized block is one which has been accepted as canonical by more than 2/3 of validators. To create a conflicting block, an attacker would have to burn at least 1/3 of the total stake.
A safe head block is one which, under normal network conditions, is expected to be included in the canonical chain. Assuming network delays of less than 4 seconds, an honest majority of validators and no attacks on the fork-choice rule, the safe head will never be orphaned.
I think we can use safe block during a sync
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog