check for self in one more spot #4521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
2 tasks
siladu
reviewed
Oct 12, 2022
| @@ -359,8 +359,10 @@ void checkMaintainedConnectionPeers() { | |||
| if (!localNode.isReady()) { | |||
| return; | |||
| } | |||
| final EnodeURL localEnodeURL = localNode.getPeer().getEnodeURL(); | |||
| maintainedPeers | |||
There was a problem hiding this comment.
Is there a good reason why self exists in the maintainedPeers set? Or is that being looked at separately?
There was a problem hiding this comment.
the way the code is now, at startup, you don't know your own enode at the time the static nodes are added to the maintainedPeers set, so you can't avoid adding your own enode
gezero
approved these changes
Oct 19, 2022
| maintainedPeers | ||
| .streamPeers() | ||
| .filter(peer -> !peer.getEnodeURL().getNodeId().equals(localEnodeURL.getNodeId())) |
There was a problem hiding this comment.
Is enoudeURL::equals working in this case?
macfarla
added a commit
to jflo/besu
that referenced
this pull request
Jan 10, 2023
* check for self in one more spot Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* check for self in one more spot Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sally MacFarlane macfarla.github@gmail.com
When regularly checking connections to maintained peers (static nodes), ensure connection to self is not initiated.
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog