Feature/engine api override #4190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just today there was a discussion on Discord that revealed that all CL clients already use a placeholder TTD for mainnet. So I guess the easiest would be to just use that one instead: https://discord.com/channels/595666850260713488/892088344438255616/1002018160268038164 |
garyschulte
force-pushed
the
feature/engine-api-override
branch
from
d86e2c6 to
e8cb0c5
Compare
garyschulte
force-pushed
the
feature/engine-api-override
branch
2 times, most recently
from
f121010 to
9810255
Compare
garyschulte
force-pushed
the
feature/engine-api-override
branch
3 times, most recently
from
2963642 to
6a6e67c
Compare
* remove reliance on isMergeEnabled in pre-merge block header validation rules * create a merge-specific block header validtion stack rather than leveraging mainnet * re-add --engine-api-enabled cli param Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
leaves the door open to supporting the engine api with other MiningCoordinators, but disables all but engine_exchangeTransitionConfiguration in the absence of mergeCoordinator Signed-off-by: garyschulte <garyschulte@gmail.com>
…ation Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
feature/engine-api-override
branch
from
6a6e67c to
922fc18
Compare
jflo
approved these changes
Jul 31, 2022
| @@ -166,10 +166,10 @@ public JsonRpcResponse syncResponse(final JsonRpcRequestContext requestContext) | |||
| final var block = | |||
| new Block(newBlockHeader, new BlockBody(transactions, Collections.emptyList())); | |||
|
|
|||
| if (mergeContext.isSyncing() || parentHeader.isEmpty()) { | |||
| if (mergeContext.map(c -> c.isSyncing()).orElse(Boolean.TRUE) || parentHeader.isEmpty()) { | |||
There was a problem hiding this comment.
This is kinda hard to read. It looks like it evaluates to a no-op, does anyone else find this harder to read?
There was a problem hiding this comment.
I can see how it is harder to read, it is a side effect of making mergeContext an Optional. looking for an approach that is easier on the 👀
There was a problem hiding this comment.
Supplier/function reference ftw 👍
…ad in engine-api Signed-off-by: garyschulte <garyschulte@gmail.com>
This was referenced Aug 2, 2022
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* initial impl of engine-api override: * remove reliance on isMergeEnabled in pre-merge block header validation rules * create a merge-specific block header validtion stack rather than leveraging mainnet * re-add --engine-api-enabled cli param * make engine api usable without a merge config. leaves the door open to supporting the engine api with other MiningCoordinators, but disables all but engine_exchangeTransitionConfiguration in the absence of mergeCoordinator Signed-off-by: garyschulte <garyschulte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Allow besu to have the engine api enabled, when there are not merge configs. includes:
--engine-rpc-enabledTested with Hive and Kurtosis since this affects block validation. Both are 🟢
Fixed Issue(s)
fixes #4172
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog