add sepolia mergeNetSplit block #4158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyschulte
force-pushed
the
feature/sepolia-fork-id
branch
from
8c003b9 to
4868c91
Compare
garyschulte
changed the title
jflo
approved these changes
Jul 26, 2022
| @@ -12,7 +12,7 @@ | |||
| "istanbulBlock": 0, | |||
| "berlinBlock": 0, | |||
| "londonBlock": 0, | |||
| "parisBlock": 1000, | |||
| "mergeNetSplitBlock": 1000, | |||
There was a problem hiding this comment.
I'm assuming this is a guess, since merge was later than block 1000. I think this will break Kiln clients, not sure if we care...
There was a problem hiding this comment.
yeah, this is just a renaming of the parisBlock, so it shouldn't further break anything. But I will look at other execution clients and see what their mergeNetSplitBlock is for paris just to make sure it is the same.
There was a problem hiding this comment.
Signed-off-by: garyschulte <garyschulte@gmail.com>
…nditions test Signed-off-by: garyschulte <garyschulte@gmail.com>
…kNumber configs for sepolia Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
garyschulte
force-pushed
the
feature/sepolia-fork-id
branch
from
faf8772 to
156dad8
Compare
Signed-off-by: garyschulte <garyschulte@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* add sepolia paris / mergeNetSplit block * fix test looking for old premerge fork alias, add sepolia terminal conditions test * rename to mergeNetSplit, ditch the terminalBlockHash and terminalBlockNumber configs for sepolia Signed-off-by: garyschulte <garyschulte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: garyschulte garyschulte@gmail.com
PR description
Add sepolia fork next, aka mergeNetSplitBlock. see ethereum/execution-specs#564
Also:
Fixed Issue(s)
fixes #4157
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog