Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BESU-179] getSignerMetrics doesn't return missing signers #343

Conversation

matkt
Copy link
Contributor

@matkt matkt commented Jan 29, 2020

Signed-off-by: Karim TAAM karim.t2am@gmail.com

PR description

getSignerMetrics doesn't return missing signers (validators who never proposed a block are not displayed). This means to find missing signers you have to use getSigners followed by getSignerMetrics and manually figure out which ones are missing.

Fixed Issue(s)

getSignerMetrics returns now missing signers

Example with 0x12eb759f2222d7711c63729a45c3585731521d02

{
  "jsonrpc": "2.0",
  "id": 1,
  "result": [
    {
      "address": "0x6639adb0e64884dc4cd9d686c15ba1ca1885c24e",
      "proposedBlockCount": "0x22",
      "lastProposedBlockNumber": "0xb8"
    },
    {
      "address": "0x12eb759f2222d7711c63729a45c3585731521d02",
      "proposedBlockCount": "0x0",
      "lastProposedBlockNumber": "0x0"
    },
    {
      "address": "0x187ec8a86cdd7e71e2c0e72affe48b727f894877",
      "proposedBlockCount": "0x21",
      "lastProposedBlockNumber": "0xb7"
    },
    {
      "address": "0x9cd90ee9290637030073f2b32884b9fa1fc0c06b",
      "proposedBlockCount": "0x21",
      "lastProposedBlockNumber": "0xb6"
    }
  ]
}

matkt added 3 commits January 29, 2020 22:11
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
@matkt matkt marked this pull request as ready for review January 29, 2020 22:50
Copy link
Contributor

@AbdelStark AbdelStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@AbdelStark AbdelStark merged commit b802fa7 into hyperledger:master Jan 30, 2020
@AbdelStark AbdelStark deleted the feature/besu-179-fix-get-signer-metrics-missing-validators branch January 30, 2020 08:10
siladu pushed a commit to siladu/besu that referenced this pull request Oct 28, 2024
* fix(blob): broken links

* Update src/engine/experimental/blob-extension.md

Co-authored-by: Mikhail Kalinin <noblesse.knight@gmail.com>

Co-authored-by: Mikhail Kalinin <noblesse.knight@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants