Add new fork for london, baikal and aleut #2237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
garyschulte
reviewed
May 6, 2021
| // TODO EIP-1559 change for the actual fork name when known | ||
| getEIP1559BlockNumber().ifPresent(l -> builder.put("aleutblock", l)); | ||
|
|
||
| getLondonBlockNumber().ifPresent(l -> builder.put("londonBlock", l)); |
There was a problem hiding this comment.
do we not also need baikalBlockNumber? or are you thinking we will just going to use londonBlock only and keep aleut for backward compatibility?
There was a problem hiding this comment.
No we did this for the Berlin testnets (yoloBlock) . In the genesis we will have baikalBlock and internally we consider it as a londonBlocK. We will remove this mechanism after testing.
For aleut we need it because, for now, is different from London. Aleut is a testnet with just EIP1559 and BASEFEE while baikal is a testnet that wants to be like london (with all EIPS).
For now for retro compatibility I prefer to keep it like that. To avoid consensus issue in this testnet
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
garyschulte
approved these changes
May 7, 2021
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
…r#2237) Signed-off-by: Karim TAAM <karim.t2am@gmail.com> Co-authored-by: garyschulte <garyschulte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Karim TAAM karim.t2am@gmail.com
PR description
Changing the code to have :
Changelog