update json-rpc responses for 1559 #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyschulte
changed the title
matkt
reviewed
May 5, 2021
| @@ -198,6 +206,11 @@ public String getGasLimit() { | |||
| return gasLimit; | |||
| } | |||
|
|
|||
| @JsonGetter(value = "gasTarget") | |||
There was a problem hiding this comment.
Do we want to add tests for impacted RPC methods in the case of an eip1559 transaction ?
There was a problem hiding this comment.
I was thinking the same thing actually. This PR is probably best to wait until next week to merge, so we can implement whatever the consensus is from the london readiness call where json-rpc format will be discussed (hopefully finalized)
There was a problem hiding this comment.
I added serialization tests for the added fields, and removed gasTarget in favor of gasLimit. should be gtg
matkt
approved these changes
May 17, 2021
| throw new InvalidJsonRpcParameters("gasPrice cannot be used with baseFee or feeCap"); | ||
| && (callParams.getMaxFeePerGas().isPresent() | ||
| || callParams.getMaxPriorityFeePerGas().isPresent())) { | ||
| throw new InvalidJsonRpcParameters("gasPrice cannot be used with baseFee or maxFeePerGas"); |
There was a problem hiding this comment.
I think it's an old issue but we need to replace baseFee in the message (maxPriorityFeePerGas ?)
…ck config fixes #2192 Signed-off-by: garyschulte <garyschulte@gmail.com>
…regression Signed-off-by: garyschulte <garyschulte@gmail.com>
… field names Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: Gary Schulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
…less Signed-off-by: garyschulte <garyschulte@gmail.com>
Signed-off-by: garyschulte <garyschulte@gmail.com>
This was referenced May 20, 2021
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* address assumption that if 1559 is enabled there is a london fork block config fixes hyperledger#2192 Signed-off-by: garyschulte <garyschulte@gmail.com> * omit null chainId from transaction json serialization, and fix merge regression Signed-off-by: garyschulte <garyschulte@gmail.com> * update json-rpc responses for 1559, use current feeCap and gasPremium field names Signed-off-by: garyschulte <garyschulte@gmail.com> * add pr number to changelog Signed-off-by: garyschulte <garyschulte@gmail.com> * fix transaction decoder Signed-off-by: Gary Schulte <garyschulte@gmail.com> * rebase and fix merge conflicts Signed-off-by: garyschulte <garyschulte@gmail.com> * remove null chainId from json-rpc test fixtures Signed-off-by: garyschulte <garyschulte@gmail.com> * the great 1559 rename Signed-off-by: garyschulte <garyschulte@gmail.com> * re-remove gasTarget Signed-off-by: garyschulte <garyschulte@gmail.com> * add serialization tests for 1559 transaction fields Signed-off-by: garyschulte <garyschulte@gmail.com> * add json property ordering annotations to Transaction*Result and spotless Signed-off-by: garyschulte <garyschulte@gmail.com> * rebase on master, update error message feedback from Karim Signed-off-by: garyschulte <garyschulte@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: garyschulte garyschulte@gmail.com
PR description
Fixed Issue(s)
fixes #2215
fixes #2287
Changelog