Update eth_call handling of account balance #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling `eth_call` by default account balances will be ignored when executing the call. If the user wants the gas balance to be a consideration in the call a new `strict` param in the call params can be set to true, which will enforce the balance rules. This is the same behavior as is observed in `eth_estimateGas`. Addresses hyperledger#502 Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
RatanRSur
approved these changes
Jan 26, 2021
macfarla
reviewed
Jan 27, 2021
| @@ -5,6 +5,7 @@ | |||
| ### 21.2 Breaking Changes | |||
| * `--skip-pow-validation-enabled` is now an error with `block import --format JSON`. This is because the JSON format doesn't include the nonce so the proof of work must be calculated. | |||
| * `eth_call` will not return a JSON-RPC result if the call fails, but will return an error instead. If it was for a revert the revert reason will be included. | |||
| * `eth_call` will not fail for account balance issues by default. An parameter `"strict": true` can be added to the call parameters (with `to` and `from`) to enforce balance checks. | |||
shemnon
added
the
doc-change-required
|
Doc change is to note something like "When using |
15 tasks
bgravenorst
removed
the
doc-change-required
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
When calling `eth_call` by default account balances will be ignored when executing the call. If the user wants the gas balance to be a consideration in the call a new `strict` param in the call params can be set to true, which will enforce the balance rules. This is the same behavior as is observed in `eth_estimateGas`. Addresses hyperledger#502 Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
eth_callby default account balances will be ignored whenexecuting the call. If the user wants the gas balance to be a
consideration in the call a new
strictparam in the call params can beset to true, which will enforce the balance rules. This is the same
behavior as is observed in
eth_estimateGas.Addresses #502
Signed-off-by: Danno Ferrin danno.ferrin@gmail.com
Changelog