Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1476] Fixed transaction validation bug when local permissioning is enabled #1510

Merged
merged 6 commits into from
Nov 4, 2020

Conversation

mark-terry
Copy link
Contributor

PR description

Updates transaction validation to address the case where a node, with local permissioning enabled, tries to import a block containing a transaction from an account that's not in its allowlist and throws an InvalidBlockException.

Fixed Issue(s)

Fixes #1476

Changelog

@mark-terry mark-terry added TeamRevenant GH issues worked on by Revenant Team permissioning account or node permissioning labels Nov 2, 2020
@mark-terry mark-terry self-assigned this Nov 2, 2020
…nabled.

Signed-off-by: Mark Terry <mark.terry@consensys.net>
mark-terry and others added 3 commits November 3, 2020 00:29
Signed-off-by: Mark Terry <mark.terry@consensys.net>
Signed-off-by: Mark Terry <mark.terry@consensys.net>
Copy link
Member

@lucassaldanha lucassaldanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a few suggestions.

mark-terry and others added 2 commits November 4, 2020 21:44
Signed-off-by: Mark Terry <mark.terry@consensys.net>
@mark-terry mark-terry merged commit 32e7f2d into hyperledger:master Nov 4, 2020
@mark-terry mark-terry deleted the 1476 branch November 4, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
permissioning account or node permissioning TeamRevenant GH issues worked on by Revenant Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behaviour when using local account permissioning
2 participants