Fix Internal error returned on eth_estimateGas #1478
Conversation
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
| @@ -23,6 +23,8 @@ | |||
|
|
|||
| private Gas sStoreStipendNeeded = Gas.ZERO; | |||
|
|
|||
| private boolean isReverted = false; | |||
There was a problem hiding this comment.
Instead of storing the revert flag in the tracer is it possible to use org.hyperledger.besu.ethereum.mainnet.TransactionProcessor.Result#getRevertReason? (via org.hyperledger.besu.ethereum.transaction.TransactionSimulatorResult#getResult)? If a TX reverts without a reason do we get an empty revert reason or a revert reason with zero bytes?
There was a problem hiding this comment.
Im thinking since this is only set by the revert operation and BLS precompiles that the optional will not be empty, at worst an optional of a zero length string
There was a problem hiding this comment.
I just tried again and indeed we don't have an empty. I thought I found a specific case where it didn't work. but after doing it again it seems ok with your technique
There was a problem hiding this comment.
good catch. I just updated the code to use getRevertReason
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
Signed-off-by: Karim TAAM <karim.t2am@gmail.com>
matkt
force-pushed
the
feature/internal-error-returned-on-eth-estimate-gas
branch
from
d962e49 to
74c33df
Compare
matkt
deleted the
feature/internal-error-returned-on-eth-estimate-gas
branch
Signed-off-by: Karim TAAM karim.t2am@gmail.com
PR description
Will return "execution reverted" in case of a revert instead of "Internal error"
{ "code": -32000, "message": "Execution reverted" }Test performed (with and without reverted transaction)
Changelog