-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change getByBlockNumber to be getByBlockHeader #4789
Comments
This was referenced Dec 8, 2022
Partial work of the trivial replaces done here: https://github.com/gfukushima/besu/tree/replace-getByBlockNumber-by-getByBlockHeader. Missing a few fixes for the tests. |
2 tasks
3 tasks
Bug found during goerli sync: #5064 |
7 tasks
This was referenced Mar 6, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Following #4743
We should update all the usages we can to be getByBlockHeader and phase out getByBlockNumber.
getByBlockNumber can cause issues in a post-shanghai (TimestampSchedule-enabled) chain.
This has been intentionally separated out of #4743 so it doesn't make the PR huge, see this spike for an idea of what the changes might look like: #4687
Another related item for clean-up:
#4743 (comment)
Tasks
The text was updated successfully, but these errors were encountered: