Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$mol_view_tree2_to_js fix indexes #665

Merged
merged 1 commit into from
Feb 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion view/tree2/to/js/js.ts
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ namespace $ {
ref.struct( '[]', [
ref.data( ref.kids[0]?.type ? name_of.call(this, ref.kids[0]) : name ),
] ),
ref.struct( '(,)' )
ref.kids[0]?.type ? params_of.call(this, ref.kids[0]) : ref.struct( '(,)' )
]),
] ),
],
Expand Down
10 changes: 9 additions & 1 deletion view/tree2/to/js/test/js.bidi.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,15 @@ namespace $ {
a!? $mol_view
expanded <=> cell_test_expanded!? null
`)
}, 'Required prop like some*? at `.view.tree#3:7/3` at .view.tree#3:7/3' )
}, `Required prop like some*? at \`.view.tree#4:21/20\`
<=>
.view.tree#4:17/3
expanded
.view.tree#4:8/8
$mol_view
.view.tree#3:11/9
a!?
.view.tree#3:7/3` )
},

'Bidi bind with default object'( $ ) {
Expand Down
16 changes: 11 additions & 5 deletions view/tree2/to/js/test/js.simple.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,15 @@ namespace $ {
$mol_assert_fail(() => {
$mol_view_tree2_to_js_test_run(`
Foo $mol_object
sub / <= Close_icon $mol_object
sub / <= Чlose_icon $mol_object
`)
}, 'Required prop like some*? at `.view.tree#3:16/10`\n<=\n.view.tree#3:13/2\n/\n.view.tree#3:11/1 at .view.tree#3:7/3')
}, `Required prop like some*? at \`.view.tree#3:16/10\`
<=
.view.tree#3:13/2
/
.view.tree#3:11/1
sub
.view.tree#3:7/3`)
},

'simple empty legacy indexed channel throws error'( $ ) {
Expand All @@ -83,14 +89,14 @@ namespace $ {
Foo $mol_object
a!? null
`)
}, 'Required prop like some*? at `.view.tree#3:7/3` at .view.tree#3:7/3' )
}, 'Required prop like some*? at `.view.tree#3:7/3`' )

$mol_assert_fail(() => {
$mol_view_tree2_to_js_test_run(`
Foo $mol_object
b! 1
`)
}, 'Required prop like some*? at `.view.tree#3:7/2` at .view.tree#3:7/2' )
}, 'Required prop like some*? at `.view.tree#3:7/2`' )
},

'simple two classes'( $ ) {
Expand Down Expand Up @@ -168,7 +174,7 @@ namespace $ {
Foo $mol_object
item_чount 50
`)
}, 'Required prop like some*? at `.view.tree#3:7/10` at .view.tree#3:7/10')
}, 'Required prop like some*? at `.view.tree#3:7/10`')
},
})

Expand Down
Loading