Skip to content
This repository was archived by the owner on Jan 3, 2019. It is now read-only.

Updates to latest brave, supporting route-based span names #58

Merged
merged 1 commit into from
Feb 23, 2018

Conversation

codefromthecrypt
Copy link
Contributor

this tests the api design here openzipkin/brave#602

@hyleung
Copy link
Owner

hyleung commented Feb 16, 2018

I guess once this stuff is moved into the adapter, we can deprecate or remove kludgy stuff from SpanNameProvider 😁

https://github.com/hyleung/ratpack-zipkin/blob/master/src/main/java/ratpack/zipkin/SpanNameProvider.java#L11-L25

@codefromthecrypt codefromthecrypt force-pushed the path-template branch 2 times, most recently from 751999e to 304b64e Compare February 23, 2018 04:37
@codefromthecrypt codefromthecrypt changed the title WIP Updates to support http template parsing Updates to latest brave, supporting route-based span names Feb 23, 2018
@codefromthecrypt
Copy link
Contributor Author

ok did the minimum here. We can decide whether or not to remove the span namer independently

@codecov
Copy link

codecov bot commented Feb 23, 2018

Codecov Report

Merging #58 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #58      +/-   ##
============================================
+ Coverage     81.85%   82.14%   +0.28%     
- Complexity       41       46       +5     
============================================
  Files             7        7              
  Lines           248      252       +4     
  Branches          8       11       +3     
============================================
+ Hits            203      207       +4     
  Misses           35       35              
  Partials         10       10
Impacted Files Coverage Δ Complexity Δ
...tpack/zipkin/internal/RatpackHttpServerParser.java 80% <ø> (ø) 5 <0> (ø) ⬇️
...ava/ratpack/zipkin/internal/ServerHttpAdapter.java 100% <100%> (ø) 13 <6> (+5) ⬆️
.../main/java/ratpack/zipkin/ServerTracingModule.java 85.71% <100%> (-0.21%) 6 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c206995...316bf15. Read the comment docs.

@codefromthecrypt
Copy link
Contributor Author

going to bump for a patch release in a bit

@codefromthecrypt
Copy link
Contributor Author

ok ready to go. tested with the example app

screen shot 2018-02-23 at 10 25 36 pm

Copy link
Owner

@hyleung hyleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codefromthecrypt codefromthecrypt merged commit 96ee16c into master Feb 23, 2018
@codefromthecrypt codefromthecrypt deleted the path-template branch February 23, 2018 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants