Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doctest] Add configuration_encoder_decoder.py #26519

Conversation

SrijanSahaySrivastava
Copy link
Contributor

What does this PR do?

Fixes #19487

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Added configuration_encoder_decoder.py to utils/documentation_tests.txt for doctest
add configuration_encoder_decoder.py to utils/documentation_tests.txt
add configuration_encoder_decoder.py to utils/documentation_tests.txt
add configuration_encoder_decoder.py to utils/documentation_tests.txt
@SrijanSahaySrivastava
Copy link
Contributor Author

@ydshieh please look into this. I'm to this.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. Left a few comments to address :-)

@@ -43,15 +43,15 @@ class EncoderDecoderConfig(PretrainedConfig):
Examples:

```python
>>> from transformers import BertConfig, EncoderDecoderConfig, EncoderDecoderModel
>>> from transformers import EncoderDecoderModel, EncoderDecoderConfig, BertConfig
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep the previous order.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did it, please check.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is no longer used. Could you revert the change here. Then remove the entry src/transformers/models/encoder_decoder/configuration_encoder_decoder.py from the list utils/not_doctested.txt.

@@ -43,15 +43,15 @@ class EncoderDecoderConfig(PretrainedConfig):
Examples:

```python
>>> from transformers import BertConfig, EncoderDecoderConfig, EncoderDecoderModel
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line should not be changed, keep it as BertConfig, EncoderDecoderConfig, EncoderDecoderModel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya, i fixed it again, please review and give feedback. Thank you <3

if it is possible, may i contact you on discord. i want to ask some questions regarding opensource and contributing to huggingface etc.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🤗

@ydshieh ydshieh merged commit 245da7e into huggingface:main Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔥[Community Event] Doc Tests Sprint - Configuration files🔥
3 participants