-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doctest] Add configuration_encoder_decoder.py
#26519
[Doctest] Add configuration_encoder_decoder.py
#26519
Conversation
Added configuration_encoder_decoder.py to utils/documentation_tests.txt for doctest
This reverts commit bd65353.
add configuration_encoder_decoder.py to utils/documentation_tests.txt
add configuration_encoder_decoder.py to utils/documentation_tests.txt
add configuration_encoder_decoder.py to utils/documentation_tests.txt
@ydshieh please look into this. I'm to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution. Left a few comments to address :-)
@@ -43,15 +43,15 @@ class EncoderDecoderConfig(PretrainedConfig): | |||
Examples: | |||
|
|||
```python | |||
>>> from transformers import BertConfig, EncoderDecoderConfig, EncoderDecoderModel | |||
>>> from transformers import EncoderDecoderModel, EncoderDecoderConfig, BertConfig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should keep the previous order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did it, please check.
utils/documentation_tests.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is no longer used. Could you revert the change here. Then remove the entry src/transformers/models/encoder_decoder/configuration_encoder_decoder.py
from the list utils/not_doctested.txt
.
@@ -43,15 +43,15 @@ class EncoderDecoderConfig(PretrainedConfig): | |||
Examples: | |||
|
|||
```python | |||
>>> from transformers import BertConfig, EncoderDecoderConfig, EncoderDecoderModel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line should not be changed, keep it as BertConfig, EncoderDecoderConfig, EncoderDecoderModel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heya, i fixed it again, please review and give feedback. Thank you <3
if it is possible, may i contact you on discord. i want to ask some questions regarding opensource and contributing to huggingface etc.
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🤗
What does this PR do?
Fixes #19487
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.