Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doctest] Add configuration_deberta_v2.py #19995

Merged
merged 3 commits into from
Nov 2, 2022

Conversation

Saad135
Copy link
Contributor

@Saad135 Saad135 commented Nov 1, 2022

What does this PR do?

Adds configuration_deberta_v2.py to utils/documentation_tests.txt

Based on #19487

@ydshieh can you please have a look? thanks :D

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Saad135 for the PR 🚀 . A tiny change before we could merge 🙏 .

@@ -51,6 +51,7 @@ src/transformers/models/data2vec/modeling_data2vec_audio.py
src/transformers/models/data2vec/modeling_data2vec_vision.py
src/transformers/models/deberta/configuration_deberta.py
src/transformers/models/deberta/modeling_deberta.py
src/transformers/models/deberta/configuration_deberta_v2.py
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
src/transformers/models/deberta/configuration_deberta_v2.py
src/transformers/models/deberta_v2/configuration_deberta_v2.py

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, should be fixed now :D

@Saad135 Saad135 force-pushed the debertav2_config_doctest branch from 262fb29 to 068206a Compare November 2, 2022 14:55
@Saad135 Saad135 requested a review from ydshieh November 2, 2022 14:57
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Nov 2, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and thanks again!

@ydshieh ydshieh merged commit 7487743 into huggingface:main Nov 2, 2022
@Saad135 Saad135 deleted the debertav2_config_doctest branch November 2, 2022 15:34
mpierrau pushed a commit to mpierrau/transformers that referenced this pull request Dec 15, 2022
* Add example docstring for DebertaV2Config

* Add DebertaV2Config to documentation_tests

* Fix mistake with directory name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants