-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Doctest] Add configuration_deberta.py #19968
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @Saad135! Just 2 suggestions for tiny improvements.
```python | ||
>>> from transformers import DebertaConfig, DebertaModel | ||
|
||
>>> # Initializing a DeBERTa style configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make it a bit more precise :-)
>>> # Initializing a DeBERTa microsoft/deberta-base style configuration
You can check what has been done for BertConfig
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done :D
>>> # Initializing a DeBERTa style configuration | ||
>>> configuration = DebertaConfig() | ||
|
||
>>> # Initializing a model (with random weights) from the DeBERTa style configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done :D
9f9af6d
to
50325e0
Compare
The documentation is not available anymore as the PR was closed or merged. |
>>> # Initializing a DeBERTa microsoft/deberta-base style configuration | ||
>>> configuration = DebertaConfig() | ||
|
||
>>> # Initializing a model (with random weights) from the DeBERTa microsoft/deberta-base style configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>>> # Initializing a model (with random weights) from the DeBERTa microsoft/deberta-base style configuration | |
>>> # Initializing a model (with random weights) from the microsoft/deberta-base style configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a really tiny thing :-) 🙏 and we can merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done :-)
50325e0
to
aefd9e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you again @Saad135 💯
What does this PR do?
Adds configuration_deberta.py to utils/documentation_tests.txt
Based on #19487
@ydshieh can you please have a look? thanks :D
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.