Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move plan user prompt to YAML and test text of plan prompts #591

Conversation

albertvillanova
Copy link
Member

Move plan user prompt to YAML and test text of plan prompts.

@albertvillanova
Copy link
Member Author

I was thinking that another alternative could be not to include "role" in the templates (more aligned with current code) to replace previous ["planning"]["initial_facts"] and split it into:

  • ["planning"]["initial_facts_pre_task"]
  • ["planning"]["initial_facts_task"]

],
}
input_messages = [message_prompt_facts, message_prompt_task]
input_messages = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albertvillanova I think we could merge the two messages here (system and user) into only one: this would streamline the code (by fusing initial_facts_pre_task and initial_facts_task into intiial_facts) and should not really affect performance. WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 roles, system and user, @aymeric-roucher.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes exactly, but we could merge into one! Like only one message with one role. I think the system/user differentiation is not useful here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Then, it must be user, as it contains explicit task. And I remember having seen that it can raise an error sending a request with only system role.

@albertvillanova
Copy link
Member Author

Failing test is caused by another PR merged into main.

@albertvillanova albertvillanova merged commit 1516ce8 into huggingface:main Feb 13, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants