-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move plan user prompt to YAML and test text of plan prompts #591
Move plan user prompt to YAML and test text of plan prompts #591
Conversation
I was thinking that another alternative could be not to include "role" in the templates (more aligned with current code) to replace previous ["planning"]["initial_facts"] and split it into:
|
], | ||
} | ||
input_messages = [message_prompt_facts, message_prompt_task] | ||
input_messages = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@albertvillanova I think we could merge the two messages here (system and user) into only one: this would streamline the code (by fusing initial_facts_pre_task
and initial_facts_task
into intiial_facts
) and should not really affect performance. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 2 roles, system and user, @aymeric-roucher.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes exactly, but we could merge into one! Like only one message with one role. I think the system/user differentiation is not useful here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Then, it must be user, as it contains explicit task. And I remember having seen that it can raise an error sending a request with only system role.
Failing test is caused by another PR merged into main. |
Move plan user prompt to YAML and test text of plan prompts.