Fix and test MemoryStep

[albertvillanova]

Fix and test MemoryStep.

Note:

• .dict method was raising: TypeError: asdict() should be called on dataclass instances
• .raw attribute is never used
  • Why was this attribute added? CC: @clefourrier @aymeric-roucher

TODO:

• Decide about the .raw attribute

[aymeric-roucher]

@albertvillanova the .raw attribute was added after discussions with @matthewcarbone who highlighted the need to access full raw model outputs for inspection of logs ex-post.

[matthewcarbone]

I am definitely a strong proponent of keeping all raw metadata. I think this was added in a recent PR though right? Through the logging? @aymeric-roucher

I think this is used somewhere and should be kept, but I could be wrong. There were lots of fast changes in that discussion.

[aymeric-roucher]

Yes it should be kept, even if not used anywhere else in the code base it can be useful for later inspection!

[albertvillanova]

Currently, MemoryStep.raw is never used in the code: no value is assigned to this variable.

• Before this PR, it was a class attribute (the same shared value for all instances)!
• And never used: neither assigned, nor accessed.

What we use in the code is ChatMessage.raw instead:

smolagents/src/smolagents/models.py

Lines 90 to 94 in fa1f8d0

	class ChatMessage:
	role: str
	content: Optional[str] = None
	tool_calls: Optional[List[ChatMessageToolCall]] = None
	raw: Optional[Any] = None # Stores the raw output from the API

What is the difference between these two?
CC: @aymeric-roucher @matthewcarbone

[albertvillanova]

Note that I commented the .raw attribute, because otherwise, it is a required argument for all the MemoryStep subclasses:

FAILED tests/test_memory.py::TestAgentMemory::test_initialization - TypeError: SystemPromptStep.__init__() missing 1 required positional argument: 'raw'
FAILED tests/test_memory.py::TestMemoryStep::test_initialization - TypeError: MemoryStep.__init__() missing 1 required positional argument: 'raw'
FAILED tests/test_memory.py::TestMemoryStep::test_dict - TypeError: MemoryStep.__init__() missing 1 required positional argument: 'raw'
FAILED tests/test_memory.py::TestMemoryStep::test_to_messages - TypeError: MemoryStep.__init__() missing 1 required positional argument: 'raw'
FAILED tests/test_memory.py::test_action_step_to_messages - TypeError: ActionStep.__init__() missing 1 required positional argument: 'raw'
FAILED tests/test_memory.py::test_planning_step_to_messages - TypeError: PlanningStep.__init__() missing 1 required positional argument: 'raw'
FAILED tests/test_memory.py::test_task_step_to_messages - TypeError: TaskStep.__init__() missing 1 required positional argument: 'raw'
FAILED tests/test_memory.py::test_system_prompt_step_to_messages - TypeError: SystemPromptStep.__init__() missing 1 required positional argument: 'raw'

[aymeric-roucher]

Oh, sorry, I misunderstood your question : then indeed, MemoryStep.raw is useless and should be removed, the .raw attribute is only useful for ChatMessages!

[albertvillanova]

Removed.

[aymeric-roucher]

Thank you @albertvillanova !