Additional parameters for openai client

[touseefahmed96]

fix #381

[aymeric-roucher]

@touseefahmed96 normally you shouldn't need a PR fort these parameters to work, they should work as kwargs. Tell me if it's not the case!

[albertvillanova]

@aymeric-roucher I was just looking at the base code because I thought the same.

And I think the kwargs are not passed to the client instantiation, but to the client call only.

• Client instantiation is not passed the self.kwargs:
  

  smolagents/src/smolagents/models.py

  Lines 725 to 728 in 3b5c99e

  	self.client = openai.OpenAI(
  	base_url=api_base,
  	api_key=api_key,
  	)

• The self.kwargs are only passed to the client call (through the completion_kwargs):
  

  smolagents/src/smolagents/models.py

  Lines 739 to 750 in 3b5c99e

  	completion_kwargs = self._prepare_completion_kwargs(
  	messages=messages,
  	stop_sequences=stop_sequences,
  	grammar=grammar,
  	tools_to_call_from=tools_to_call_from,
  	model=self.model_id,
  	custom_role_conversions=self.custom_role_conversions,
  	convert_images_to_image_urls=True,
  	**kwargs,
  	)
  	response = self.client.chat.completions.create(**completion_kwargs)

[touseefahmed96]

So, @albertvillanova in order to use the organization or project parameter isn't it necessary to pass kwargs to client ?
like:

 self.client = openai.OpenAI( 
     base_url=api_base, 
     api_key=api_key, 
    **kwargs,
 ) 

[aymeric-roucher]

Thanks for looking into it @albertvillanova !
Then indeed this PR makes sense!
Maybe if going forward we see many additional (and unpredictable) args needed for model initialization rather than model completion, we could add something like an initialization_args dict that users can use to pass init args to the underlying model? Not sure what would be best.

[albertvillanova]

I agree @aymeric-roucher. If in the future we see more client args are requested by users, maybe we could define a client_kwargs parameter.

[albertvillanova]

Thanks, @touseefahmed96.

[touseefahmed96]

I agree @aymeric-roucher. If in the future we see more client args are requested by users, maybe we could define a client_kwargs parameter.

I will look into it and let's see if I can find any better solution. The client_kwargs parameter makes sense