Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Text to sql example - minor naming / dedupe #376

Merged

Conversation

GrahamTheCoder
Copy link
Contributor

@GrahamTheCoder GrahamTheCoder commented Jan 27, 2025

  1. Fix name to waiters for second table
  2. Remove incorrect comment
  3. Dedupe insert row logic - it's not central to the example so shouldn't be repeated

Thanks for the library, it looks great so far.

If not useful, happy to iterate, or feel free to close the PR and fix this up a different way

Dedupe insert row logic
@GrahamTheCoder GrahamTheCoder changed the title Minor naming / dedupe Docs: Text to sql example - minor naming / dedupe Jan 27, 2025
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Just some minor comments.

@GrahamTheCoder
Copy link
Contributor Author

Thanks, I've applied those improvements
Test failed due to a "429: Too many requests" so I assume that's not related to the PR changes

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Yes, CI error is unrelated.

@albertvillanova albertvillanova merged commit 242a6e5 into huggingface:main Jan 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants