minor fix for console in AgentLogger #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if this isn't correct, just close the PR
|
since a lot of tests are failing, I guess |
|
The failing test was trying to grab console logs from the main console object, from which your proposed PR reroutes the logs away, so it wasn't grabbing its target logs anymore. Now I fixed this test to correctly listen to the agent's logs under |
aymeric-roucher
approved these changes
Jan 22, 2025
| @@ -409,7 +394,7 @@ def execute_tool_call(self, tool_name: str, arguments: Union[Dict[str, str], str | |||
| observation = available_tools[tool_name].__call__(**arguments, sanitize_inputs_outputs=True) | |||
| else: | |||
| error_msg = f"Arguments passed to tool should be a dict or string: got a {type(arguments)}." | |||
| raise AgentExecutionError(error_msg) | |||
| raise AgentExecutionError(error_msg, self.logger, self.logger) | |||
There was a problem hiding this comment.
I guess this is a typo.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if this isn't correct, just close the PR.
@aymeric-roucher