Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuse stream and direct run calls #296

Merged
merged 9 commits into from
Jan 22, 2025
Merged

Fuse stream and direct run calls #296

merged 9 commits into from
Jan 22, 2025

Conversation

clefourrier
Copy link
Member

The code is duplicated here (apart from the return management). It's going to be more robust to have one single function to avoid losing some logic changes.

@clefourrier clefourrier marked this pull request as draft January 21, 2025 15:06
@aymeric-roucher
Copy link
Collaborator

Thank you @clefourrier! I've tried doing this deduplication but I think there's a fundamental incompatibility: whenever there's a yield inside a function, it becomes a generator type, even when the yield is never accessed. If you manage to make it work however it'd be great!

@clefourrier
Copy link
Member Author

I passed it to draft when noticing this - thanks for the confirmation that it's not just me becoming crazy! XD
I'll try to get to the bottom of this 😈

@clefourrier clefourrier marked this pull request as ready for review January 21, 2025 16:38
@clefourrier
Copy link
Member Author

Héhéhé :D

@aymeric-roucher
Copy link
Collaborator

LGTM! Thanks a lot!

@aymeric-roucher
Copy link
Collaborator

image
When a PR simplifies 50 lines of your core code, thx @clefourrier

@aymeric-roucher aymeric-roucher merged commit 2c43546 into main Jan 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants