Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MODULE] Add exercises and review DPO and ORPO module #29

Merged
merged 7 commits into from
Dec 5, 2024
Merged

[MODULE] Add exercises and review DPO and ORPO module #29

merged 7 commits into from
Dec 5, 2024

Conversation

burtenshaw
Copy link
Collaborator

This PR is to finalise module 2 for release on December 6.

@burtenshaw burtenshaw requested a review from ariG23498 December 4, 2024 14:01
ariG23498
ariG23498 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@ariG23498 ariG23498 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The readme looks good to me.
You can merge if you like, I am yet to try out the notebooks.

To unblock the PR, I would vote for merging this, and then add a separate PR later if something come up.

@burtenshaw
Copy link
Collaborator Author

Thanks.

@burtenshaw burtenshaw merged commit b1705d7 into main Dec 5, 2024
zcasanova pushed a commit to zcasanova/smol-course that referenced this pull request Dec 27, 2024
@burtenshaw
Merge pull request huggingface#29 from huggingface/dpo-improvements
7db2916 
[MODULE] Add exercises and review DPO and ORPO module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarobartt alvarobartt alvarobartt left review comments

@ariG23498 ariG23498 ariG23498 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burtenshaw @alvarobartt @ariG23498