Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable generation tests #407

Merged
merged 10 commits into from
Jun 8, 2023

Conversation

kundaMwiza
Copy link
Contributor

@kundaMwiza kundaMwiza commented Jun 6, 2023

What does this PR do?

  • update generation tests structure to mirror transformers 4.29.2
  • update generation strategies in optimum/graphcore/generation/utils.py to support multiple eos token to mirror transformers 4.29.2
  • add destroy method to mirror poptorch_model.destroy()

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Collaborator

@katalinic-gc katalinic-gc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@katalinic-gc katalinic-gc merged commit 21da964 into huggingface:main Jun 8, 2023
@katalinic-gc katalinic-gc deleted the enable-generation-tests branch June 8, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants