Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(test): remove duplicated code in conftest.py #804

Merged
merged 2 commits into from
Mar 4, 2025
Merged

refactor(test): remove duplicated code in conftest.py #804

merged 2 commits into from
Mar 4, 2025

Conversation

imstevenpmwork
Copy link
Collaborator

What this does

Removes code duplication in contest.py

How it was tested

Running pytest

How to checkout & try? (for the reviewer)

Checkout the branch and run pytest

@imstevenpmwork imstevenpmwork added the tests Problems with test coverage, failures, or improvements to testing label Mar 4, 2025
@imstevenpmwork imstevenpmwork self-assigned this Mar 4, 2025
aliberts
aliberts approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@aliberts aliberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@aliberts aliberts merged commit 3827974 into main Mar 4, 2025
7 checks passed
@aliberts aliberts deleted the test/dry_conftest branch March 4, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliberts aliberts aliberts approved these changes

@Cadene Cadene Awaiting requested review from Cadene

Assignees

@imstevenpmwork imstevenpmwork

Labels
tests Problems with test coverage, failures, or improvements to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imstevenpmwork @aliberts