Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
Adds Bandit in pre-commits which is a security linter to detect common security issues in Python code.
Performs the following fixes to comply with the issues reported:
eval
->eval_main
as bandit thinks this is python's built-ineval
function (we should use builtins names anyway)timeout
value to somerequests.get
callsos.system
with the safersubprocess.run(..., shell=False)
pre-commit run -a
Deactivates a few rules after verification that this is reasonable given our usage:
Took the opportunity to update pre-commit hooks.
How it was tested
Ran
pre-commit run -a