Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refac training utils.py #9815

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

RogerSinghChugh
Copy link
Contributor

What does this PR do?

Fixes #9567

Before submitting

Who can review?

@a-r-r-o-w @stevhliu

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@stevhliu
Copy link
Member

stevhliu commented Nov 1, 2024

@sayakpaul do you happen to know why these specific tests are failing? We've tried troubleshooting (make style, make quality, push changes) in #9724 but nothing seems to be working.

@sayakpaul
Copy link
Member

@sayakpaul do you happen to know why these specific tests are failing? We've tried troubleshooting (make style, make quality, push changes) in #9724 but nothing seems to be working.

Could be because of the versioning problems locally. I have just pushed the changed with "make style && make quality". Hopefully, that cuts it.

@RogerSinghChugh
Copy link
Contributor Author

@sayakpaul do you happen to know why these specific tests are failing? We've tried troubleshooting (make style, make quality, push changes) in #9724 but nothing seems to be working.

Could be because of the versioning problems locally. I have just pushed the changed with "make style && make quality". Hopefully, that cuts it.

Hi @sayakpaul
Thank you doing that. What do you mean by versioning changes? Do you mean the versions of the library ruff and isort I have installed?
I installed ruff 0.1.5 and the latest one for isort.
Can you let me know what versions are you running?
Also if the versioning is an issue, then can we add version requirements somewhere in the guides? Could be really helpful for beginners looking to contribute.

Once again thanks @stevhliu @sayakpaul

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @sayakpaul, and thanks for your patience @RogerSinghChugh! 🤗

@stevhliu stevhliu merged commit a3cc641 into huggingface:main Nov 4, 2024
15 checks passed
sayakpaul added a commit that referenced this pull request Dec 23, 2024
* Refac training utils.py

* quality

---------

Co-authored-by: sayakpaul <spsayakpaul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[community] Improving docstrings and type hints
4 participants