Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes EMAModel "from_pretrained" method #9779

Merged
merged 8 commits into from
Nov 1, 2024

Conversation

SahilCarterr
Copy link
Contributor

What does this PR do?

Fixes #9764 Fixes EMAModel "from_pretrained" method

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed.
@yiyixuxu

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks so much.

I have left only one comment.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul sayakpaul merged commit f55f1f7 into huggingface:main Nov 1, 2024
14 of 15 checks passed
@sayakpaul
Copy link
Member

Thanks a lot for your contributions. Failing tests are unrelated.

@SahilCarterr SahilCarterr deleted the ema_model branch November 1, 2024 04:17
a-r-r-o-w pushed a commit that referenced this pull request Nov 1, 2024
* fix from_pretrained and added test

* make style

---------

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
sayakpaul added a commit that referenced this pull request Dec 23, 2024
* fix from_pretrained and added test

* make style

---------

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EMAModel class bug: "from_pretrained" method bug
3 participants