-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bugs for sd3 controlnet training #9489
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good to me.
In a future PR, I will add a few more tests related to gradient checkpointing.
Hi, any comment on this PR ? @yiyixuxu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com> Co-authored-by: YiYi Xu <yixu310@gmail.com>
Hi, I have a question on 1: Is having unused parameters expected behavior? The following parameters seem to be unused:
|
Hi, I meet the same error, do you solve it now? |
Hi, I have never met this error, could you please describe in detail, thanks! |
Seems maybe I have met before, but I'm not sure, could you please contact me with email: xduzhangjiayu@163.com for further discussion ? |
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com> Co-authored-by: YiYi Xu <yixu310@gmail.com>
What does this PR do?
This PR is for fix some bugs for sd3 controlnet training
--gradient_checkpointing
in training process (src\diffusers\models\controlnet_sd3.py)Who can review?
@yiyixuxu @sayakpaul @asomoza