[Core] add QKV fusion to AuraFlow and PixArt Sigma #8952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
yiyixuxu
approved these changes
Jul 25, 2024
Comment on lines
+1282
to
+1283
| *args, | ||
| **kwargs, |
There was a problem hiding this comment.
we do not need them, no?
Suggested change
| *args, | |
| **kwargs, |
|
@yiyixuxu because we have I had to do: LMK if you have other ideas to counter it. Without it, we will have: |
|
@yiyixuxu a friendly ping. |
6 tasks
|
@sayakpaul you're right thank you! |
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
* add fusion support to pixart * add to auraflow. * add tests * apply review feedback. * add back args and kwargs * style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As a follow-up of #8829, I decided to give QKV fusion a try for AuraFlow and PixArt-Sigma when doing int8 quantization. Some nice gains on an H100:
PixArt
AuraFlow