Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect few contributions on ethical_guidelines.md that were not reflected on #8294 #8914

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

mreraser
Copy link
Contributor

What does this PR do?

Hello!😀

In the previous PR, a few contributions from @heuristicwave regarding ethical_guidelines.md were not reflected.

@heuristicwave identified a few parts that were not reflected in the documents from the PR. I completed revisions for philosophy.md, which were included in the Reflect few contributions on philosophy.md that were not reflected on #8294. Now this PR concerns ethical_guidelines.md, and parts related to evaluation.md and contribution.md will be addressed in future PRs.

I apologize once again for these mistakes and will promptly address the issues to submit the PR as soon as possible.

from #7940

Before submitting

Who can review?

@heuristicwave @stevhliu

@heuristicwave
Copy link
Contributor

@mreraser Looks good this time, thanks for the fix, change draft to open and request a merge!

@mreraser mreraser marked this pull request as ready for review July 21, 2024 17:24
@mreraser
Copy link
Contributor Author

@mreraser Looks good this time, thanks for the fix, change draft to open and request a merge!

Thank you @heuristicwave !!! 😄

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👏

@stevhliu stevhliu merged commit 5802c2e into huggingface:main Jul 22, 2024
1 check passed
a-r-r-o-w pushed a commit that referenced this pull request Jul 22, 2024
sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants