Support LMSDiscreteScheduler in LDMPipeline #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small change to support all schedulers such as LMSDiscreteScheduler in LDMPipeline. What's changed ------- * Add the `scale_model_input` function before `step` to ensure correct denoising (L77)
|
The documentation is not available anymore as the PR was closed or merged. |
|
This looks good to me! @anton-l could you also give it a quick review :-) |
patrickvonplaten
approved these changes
Oct 20, 2022
anton-l
requested changes
Oct 21, 2022
There was a problem hiding this comment.
Great idea @mkshing, thank you!
You'll just need one more modification to make it work with LMS-like schedulers:
latents = torch.randn(
(batch_size, self.unet.in_channels, self.unet.sample_size, self.unet.sample_size),
generator=generator,
)
latents = latents.to(self.device)
+ # scale the initial noise by the standard deviation required by the scheduler
+ latents = latents * self.scheduler.init_noise_sigma Happy to merge your PR after that :)
|
@patrickvonplaten @anton-l Thank you for your review! I added 2 lines as #891 (review)! |
anton-l
approved these changes
Oct 21, 2022
|
Great PR - thanks @mkshing :-) |
PhaneeshB
pushed a commit
to nod-ai/diffusers
that referenced
this pull request
Mar 1, 2023
Co-authored-by: Elias Joseph <elias@nod-labs.com>
yoonseokjin
pushed a commit
to yoonseokjin/diffusers
that referenced
this pull request
Dec 25, 2023
* Support LMSDiscreteScheduler in LDMPipeline This is a small change to support all schedulers such as LMSDiscreteScheduler in LDMPipeline. What's changed ------- * Add the `scale_model_input` function before `step` to ensure correct denoising (L77) * Add "scale the initial noise by the standard deviation required by the scheduler" * run `make style` Co-authored-by: Anton Lozhkov <anton@huggingface.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thank you for such a great repo. This is a small change to support all schedulers such as LMSDiscreteScheduler in LDMPipeline.
What's changed
scale_model_inputfunction beforestepto ensure correct denoising (L77)