Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TensorRT img2img community pipeline #8899

Merged
merged 7 commits into from
Jul 25, 2024
Merged

Update TensorRT img2img community pipeline #8899

merged 7 commits into from
Jul 25, 2024

Conversation

asfiyab-nvidia
Copy link
Contributor

What does this PR do?

  1. Refactor TensorRT Img2Img pipeline to inherit from DiffusionPipeline
  2. Update TensorRT API to align with the latest version (10.2.0)

Before submitting

  • [ x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [ y] Did you read the contributor guideline?
  • [ y] Did you read our philosophy doc (important for complex PRs)?
  • [ x] Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
  • [ y] Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • [ x] Did you write any new necessary tests?

Who can review?

cc @yiyixuxu @asomoza

@asfiyab-nvidia
Update TensorRT img2img pipeline
5f32483 
Signed-off-by: Asfiya Baig <asfiyab@nvidia.com>
@asfiyab-nvidia
Update TensorRT version installed
fbc80e8 
Signed-off-by: Asfiya Baig <asfiyab@nvidia.com>
DN6
DN6 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@DN6 DN6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍🏽

@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@tolgacangoz
Copy link
Contributor

Thanks for the refactor!
Could you make style and quality proper :)

@asfiyab-nvidia
make style and quality
442ab2d 
Signed-off-by: Asfiya Baig <asfiyab@nvidia.com>
@asfiyab-nvidia
Copy link
Contributor Author

@tolgacangoz thanks for the link. Updated the style and quality in a follow up commit

tolgacangoz
tolgacangoz approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@tolgacangoz tolgacangoz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor! I just suggested simplifying. Also, running make style && make quality for full formatting is necessary.

asfiyab-nvidia and others added 2 commits July 22, 2024 12:35
@asfiyab-nvidia @tolgacangoz
Update examples/community/stable_diffusion_tensorrt_img2img.py
2578d5b 
Co-authored-by: Tolga Cangöz <46008593+tolgacangoz@users.noreply.github.com>
@asfiyab-nvidia @tolgacangoz
Update examples/community/README.md
6d6debf 
Co-authored-by: Tolga Cangöz <46008593+tolgacangoz@users.noreply.github.com>
@asfiyab-nvidia
Copy link
Contributor Author

Thanks for the refactor! I just suggested simplifying. Also, running make style && make quality for full formatting is necessary.

Thanks for the suggested simplifications - committed them.
Running make style && make quality resulted in the changes in commit. Is there more I'm missing?

@tolgacangoz
Copy link
Contributor

tolgacangoz commented Jul 23, 2024 •
edited
Loading

Is your ruff's version 0.1.5? Could you run make style && make quality after revoking the last commit and python -m pip install -e ".[dev]"?

@asfiyab-nvidia asfiyab-nvidia force-pushed the dev-update-trt-img2img branch from bb1d507 to 6d6debf Compare July 23, 2024 17:27
@asfiyab-nvidia
Apply style and quality using ruff 0.1.5
0248ae0 
Signed-off-by: Asfiya Baig <asfiyab@nvidia.com>
@asfiyab-nvidia
Copy link
Contributor Author

Is your ruff's version 0.1.5? Could you run make style && make quality after revoking the last commit and python -m pip install -e ".[dev]"?

Updated using ruff 0.1.5 in the latest commit. Hope this passes the style checker

@tolgacangoz
Copy link
Contributor

LGTM; thanks!

@asfiyab-nvidia
Copy link
Contributor Author

@DN6 @tolgacangoz Can I get help moving this PR along? I looked at both failures and they seem unrelated to community pipeline change I made

@DN6 DN6 merged commit 0bda1d7 into huggingface:main Jul 25, 2024
8 checks passed
sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
@asfiyab-nvidia @tolgacangoz
@DN6 @sayakpaul
Update TensorRT img2img community pipeline (#8899)
d1e1676 
* Update TensorRT img2img pipeline

Signed-off-by: Asfiya Baig <asfiyab@nvidia.com>

* Update TensorRT version installed

Signed-off-by: Asfiya Baig <asfiyab@nvidia.com>

* make style and quality

Signed-off-by: Asfiya Baig <asfiyab@nvidia.com>

* Update examples/community/stable_diffusion_tensorrt_img2img.py

Co-authored-by: Tolga Cangöz <46008593+tolgacangoz@users.noreply.github.com>

* Update examples/community/README.md

Co-authored-by: Tolga Cangöz <46008593+tolgacangoz@users.noreply.github.com>

* Apply style and quality using ruff 0.1.5

Signed-off-by: Asfiya Baig <asfiyab@nvidia.com>

---------

Signed-off-by: Asfiya Baig <asfiyab@nvidia.com>
Co-authored-by: Tolga Cangöz <46008593+tolgacangoz@users.noreply.github.com>
Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DN6 DN6 DN6 approved these changes

@tolgacangoz tolgacangoz tolgacangoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asfiyab-nvidia @HuggingFaceDocBuilderDev @tolgacangoz @DN6