[Tests] add test suite for SD3 DreamBooth #8650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayakpaul
changed the title
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Will add more tests for prior preservation too in a separate PR once I fix it (reference: #8589). |
asomoza
approved these changes
Jun 29, 2024
|
Really great idea!. Actually it helps a lot. I wanted to test it and all the tests fails for me and I know why, so I'll open a PR to fix it. |
|
@asomoza which tests are you referring to? |
|
Tested the lora ones: pytest examples/dreambooth/test_dreambooth_lora_sd3.py
============================================================ test session starts =============================================================
platform linux -- Python 3.12.3, pytest-8.2.2, pluggy-1.5.0
configfile: pyproject.toml
plugins: requests-mock-1.10.0, xdist-3.6.1, timeout-2.3.1
collected 3 items
examples/dreambooth/test_dreambooth_lora_sd3.py FFF [100%]
========================================================== short test summary info ===========================================================
FAILED examples/dreambooth/test_dreambooth_lora_sd3.py::DreamBoothLoRASD3::test_dreambooth_lora_sd3 - test_examples_utils.SubprocessCallException: Command `accelerate launch --config_file /tmp/tmp2yatc1ok/default_config.yml examples/dreamb...
FAILED examples/dreambooth/test_dreambooth_lora_sd3.py::DreamBoothLoRASD3::test_dreambooth_lora_sd3_checkpointing_checkpoints_total_limit - test_examples_utils.SubprocessCallException: Command `accelerate launch --config_file /tmp/tmp2yatc1ok/default_config.yml examples/dreamb...
FAILED examples/dreambooth/test_dreambooth_lora_sd3.py::DreamBoothLoRASD3::test_dreambooth_lora_sd3_checkpointing_checkpoints_total_limit_removes_multiple_checkpoints - test_examples_utils.SubprocessCallException: Command `accelerate launch --config_file /tmp/tmp2yatc1ok/default_config.yml examples/dreamb...
============================================================= 3 failed in 27.89s =============================================================After applying #8743: ============================================================ test session starts =============================================================
platform linux -- Python 3.12.3, pytest-8.2.2, pluggy-1.5.0
configfile: pyproject.toml
plugins: requests-mock-1.10.0, xdist-3.6.1, timeout-2.3.1
collected 3 items
examples/dreambooth/test_dreambooth_lora_sd3.py ... [100%]
============================================================= 3 passed in 40.13s ============================================================= |
|
Maybe it's worth to add a second test with the |
|
Thanks everyone for chiming in for this PR :) |
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
* add a test suite for SD3 DreamBooth * lora suite * style * add checkpointing tests for LoRA * add test to cover train_text_encoder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
SD3 training will be crucial in the coming days and we would want to ensure robustness for our canonical scripts. So, this PR adds test suites for the LoRA and non-LoRA DreamBooth scripts.