Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keepalive timeout not configurable #404

Closed
nestegg opened this issue Apr 12, 2017 · 4 comments
Closed

keepalive timeout not configurable #404

nestegg opened this issue Apr 12, 2017 · 4 comments

Comments

@nestegg
Copy link
Contributor

nestegg commented Apr 12, 2017 •
edited
Loading

I'm trying to keep a persistent connection open to a finicky API and am running into issues with the the keepalive timeout. A few questions:

The default timeout is set very short (5 seconds). What's the rationale for this?

It is not configurable through the API. Is this deliberate or an oversight?

If I were to provide a PR to address this, I'm thinking this should be an option passed to persistent() rather than timeout(). Thoughts?
@ixti
Copy link
Member

ixti commented Apr 12, 2017

The reason for 5 seconds is it's default for apache https 2.2+, but I totally agree this should be configurable. It should be an option of #persistent - will be happy to review PR.

@dgollahon
Copy link

I was about to ask about the status of this but it looks like it was addressed in 4738d22.

I have a use case for this feature and would prefer to depend on a full version instead of a git revision. Any chance of a release in the near future?

Thanks for all the great work on http!

@ixti
Copy link
Member

ixti commented Apr 24, 2017

@dgollahon Sure. Completely forgot to cut release. Will do in the nearest future

@ixti
Copy link
Member

ixti commented Apr 27, 2017

@dgollahon released as 2.2.2

@ixti ixti closed this as completed Apr 27, 2017
jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Jun 5, 2017
Update ruby-http to 2.2.2.
36145d3 
## 2.2.2 (2017-04-27)

* [#404](httprb/http#404),
  [#405](httprb/http#405)
  Make keepalive timeout configurable.
  ([@nestegg])
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nestegg @ixti @dgollahon