Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regexp change for future compatibility. Fixes #347 #379

Merged
merged 1 commit into from
Nov 30, 2017
Merged

Regexp change for future compatibility. Fixes #347 #379

merged 1 commit into from
Nov 30, 2017

Conversation

mvasilkov
Copy link
Contributor

Le this: #347

@codecov-io
Copy link

codecov-io commented Nov 30, 2017

Codecov Report

Merging #379 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #379   +/-   ##
=======================================
  Coverage   90.76%   90.76%           
=======================================
  Files          50       50           
  Lines        6950     6950           
  Branches     1328     1328           
=======================================
  Hits         6308     6308           
  Misses        483      483           
  Partials      159      159
Impacted Files Coverage Δ
html5lib/_inputstream.py 91.62% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4a85fc...3e86e49. Read the comment docs.

Copy link
Contributor

@willkg willkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified that this covers what was asked for in issue #347. Thank you for doing this!

@willkg willkg merged commit af35626 into html5lib:master Nov 30, 2017
@mvasilkov mvasilkov deleted the patch-1 branch November 30, 2017 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants