Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/rework proj create cont #2230

Merged
merged 9 commits into from
Feb 25, 2025

Conversation

NSUWAL123
Copy link
Contributor

@NSUWAL123 NSUWAL123 commented Feb 25, 2025

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

  • If no dataExtract uploaded or fetched, disable next btn
  • Use radio option label as id for radiobutton to fix conflict between two radio geometry selections
  • Fix text highlighting on left for Upload Survey and Map Data tabs
  • Fix spacing issues
  • Fix: if validation logic is triggered that form is not attached, then a form is uploaded afterwards, the validation message does not disappear

Screenshots

image
image

pre-commit-ci bot and others added 9 commits February 24, 2025 19:20
updates:
- [github.com/commitizen-tools/commitizen: v4.2.1 β†’ v4.2.2](commitizen-tools/commitizen@v4.2.1...v4.2.2)
- [github.com/astral-sh/ruff-pre-commit: v0.9.6 β†’ v0.9.7](astral-sh/ruff-pre-commit@v0.9.6...v0.9.7)
- [github.com/astral-sh/uv-pre-commit: 0.6.0 β†’ 0.6.2](astral-sh/uv-pre-commit@0.6.0...0.6.2)
- [github.com/pycontribs/mirrors-prettier: v3.5.1 β†’ v3.5.2](pycontribs/mirrors-prettier@v3.5.1...v3.5.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@NSUWAL123 NSUWAL123 requested a review from spwoodcock February 25, 2025 07:02
@github-actions github-actions bot added enhancement New feature or request frontend Related to frontend code labels Feb 25, 2025
Copy link
Member

@spwoodcock spwoodcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the quick fixes here!

Great combined effort πŸ’ͺ

@spwoodcock spwoodcock merged commit 9e2f201 into feat/rework-proj-create Feb 25, 2025
2 checks passed
@spwoodcock spwoodcock deleted the feat/rework-proj-create-cont branch February 25, 2025 10:29
spwoodcock added a commit that referenced this pull request Feb 25, 2025
… (during proj create) (#2225)

* Revert "fix(backend): set new_geom_type default to Polygon as temp fix for #2164"

This reverts commit 400ed11.

* fix(backend): ignore missing token warning for auth checks

* build: migration to rename xform_category --> osm_category

* refactor(createProject): set primary_geom_type and new_geom_type fields

* build: update to latest osm-fieldwork for change to form_category

* feat(projectCreate): option to specify new_geom_type and primary_geom_type separately

* fix: correctly handle osm data extracts using enum from form type

* Feat/rework proj create cont (#2230)

* [pre-commit.ci] pre-commit autoupdate (#2224)

updates:
- [github.com/commitizen-tools/commitizen: v4.2.1 β†’ v4.2.2](commitizen-tools/commitizen@v4.2.1...v4.2.2)
- [github.com/astral-sh/ruff-pre-commit: v0.9.6 β†’ v0.9.7](astral-sh/ruff-pre-commit@v0.9.6...v0.9.7)
- [github.com/astral-sh/uv-pre-commit: 0.6.0 β†’ 0.6.2](astral-sh/uv-pre-commit@0.6.0...0.6.2)
- [github.com/pycontribs/mirrors-prettier: v3.5.1 β†’ v3.5.2](pycontribs/mirrors-prettier@v3.5.1...v3.5.2)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* chore(deps): update dependency @types/geojson to v7946.0.16 (#2227)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(dataExtract): if no dataExtract uploaded or fetched, disable next btn

* fix(radiobutton): use radio option label as id for radiobutton

* fix(description): update uploadSurvey desc section hover

* fix(checkbox): update styles

* refactor(style): refactor style to maintain consistent gaps in UI

* fix(selectForm): disappear validation message after form upload

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

---------

Co-authored-by: Nishit Suwal <81785002+NSUWAL123@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Related to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants