Refactor: Replace old button with new button components #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…place-old-buttons
github-actions
bot
added
enhancement
for more information, see https://pre-commit.ci
spwoodcock
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
Love this idea overall 🎉
But was wondering if in the long run we can replace components like buttons designed for FMTM with generic button components from shoelace-style?
Similar to the components we have integrated into the mapper frontend.
React 19 has first party support for web-components, so it should work well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
Previously, a new button component was made which needed to be replaced with the old button component
Describe this PR
Screenshots