Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add filters for submission date in submission table and downloads #2077

Merged
merged 4 commits into from
Jan 13, 2025
Merged

feat: add filters for submission date in submission table and downloads #2077

merged 4 commits into from
Jan 13, 2025

Conversation

Anuj-Gupta4
Copy link
Collaborator

@Anuj-Gupta4 Anuj-Gupta4 commented Jan 10, 2025 •
edited
Loading

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation
  • 🧑‍💻 Refactor
  • ✅ Test
  • 🤖 Build or CI
  • ❓ Other (please specify)

Related Issue

Describe this PR

add date range filter to submission table and download (json and zip)
refactor username filter in submission table

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@Anuj-Gupta4 Anuj-Gupta4 requested a review from Sujanadh January 10, 2025 05:54
@github-actions github-actions bot added enhancement New feature or request backend Related to backend code labels Jan 10, 2025
@github-actions github-actions bot added the tests Related to automated code tests label Jan 10, 2025
@Anuj-Gupta4
Copy link
Collaborator Author

prerequisite:

hotosm/osm-fieldwork#330

@Anuj-Gupta4 Anuj-Gupta4 marked this pull request as ready for review January 10, 2025 09:25
@Sujanadh Sujanadh marked this pull request as draft January 10, 2025 09:54
@Sujanadh Sujanadh added the dependency:osm-fieldwork Requires updates in osm-fieldwork label Jan 10, 2025
@spwoodcock
Copy link
Member

The change to osm-fieldwork has been merge, released (0.18.0) and updated in FMTM: 879f779 👍

@Anuj-Gupta4 Anuj-Gupta4 marked this pull request as ready for review January 10, 2025 15:20
spwoodcock
spwoodcock requested changes Jan 10, 2025
View reviewed changes
Copy link
Member

@spwoodcock spwoodcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it should work to me!

Just a minor comment + then we can look at the frontend implementation.

Nice work 😄

@spwoodcock spwoodcock self-requested a review January 13, 2025 15:32
@spwoodcock spwoodcock merged commit e6e1a66 into development Jan 13, 2025
5 checks passed
@spwoodcock spwoodcock deleted the refactor/submission branch January 13, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spwoodcock spwoodcock spwoodcock approved these changes

@Sujanadh Sujanadh Awaiting requested review from Sujanadh

Assignees
No one assigned
Labels
backend Related to backend code dependency:osm-fieldwork Requires updates in osm-fieldwork enhancement New feature or request tests Related to automated code tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Anuj-Gupta4 @spwoodcock @Sujanadh