-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update auth cookie logic for both backend and frontend (seamless temp auth) #1974
Conversation
Merging early so this can be tested easily, but please still review + test thoroughly everyone π When I wake up, if all is well, I will make the release π |
On refresh, the json payload was not returning with AuthUser correctly: Added commit 3a9a50f to address this, now deploying. Heading to bed, but hopefully it works π€ π΄ |
@spwoodcock The refresh endpoint for mapper worked at first. If there are no tokens and mapper frontend is accessed: Refresh management endpoint also throws error. Since same functions are being called with different parameters and response is being passed around a lot, the generated response does not always work with other functions and frontend. |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a π or π |
I think the above issue is related to the ones you fixed @Anuj-Gupta4 , but would you be able to double check its not a separate issue? π |
It is the same issue. We changed the code to use separate db pool connection for updating the background task status. |
What type of PR is this? (check all applicable)
Related Issue
Follow on from #1948
Describe this PR
Content
Review Guide
Notes for the reviewer. How to test this change?
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?