Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix xlsform question ordering + pmtile generation when custom TMS #1721

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

spwoodcock
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

Fixes #1697

Describe this PR

  • Also fixes PMTile generation when using custom TMS provider, which didn't work always previously.
  • Now we use the oam provider for osm_fieldwork.basemapper.

Review Guide

  • Generate pmtiles + mbtiles with various providers.
  • A custom TMS should be tested for both pmtiles + mbtiles too.

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

@spwoodcock spwoodcock requested a review from Sujanadh July 30, 2024 17:06
@spwoodcock spwoodcock self-assigned this Jul 30, 2024
@github-actions github-actions bot added the backend Related to backend code label Jul 30, 2024
@spwoodcock spwoodcock merged commit 9271dae into development Jul 30, 2024
5 checks passed
@spwoodcock spwoodcock deleted the fix/pmtile-basemaps branch July 30, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to backend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XLSForm questionaire should come after building validation questions
1 participant