-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace custom nginx / certbot config with BunkerWeb #1695
Conversation
I've used a turnkey-like server solution Caddy before, but this seems like it's got even more and its security focused. Looks good to me. |
Thanks! I like that it reduces the maintenance burden for building nginx images with brotli and maintaining configs π Hoping to finish this at some point & also roll it out for DroneTM eventually too π |
026e4bb
to
b78e2aa
Compare
36c0a90
to
53dd8a4
Compare
25849d1
to
242db0a
Compare
Tests failing I presume because the CI image doesn't have the correct dev cert for ODK Central. Merging pre-emptively in the hope that a new CI image build will fix this π |
What type of PR is this? (check all applicable)
Related Issue
Fixes #1686
Also fixes #1479
Related to: #1650, but does not fix it.
(the FastAPI middleware is probably required after all)
Describe this PR
Bunkerweb repo: https://github.com/bunkerity/bunkerweb/
nginx
directory and related code / configs / scripts.development
andmain
compose configs.scheduler
and docker socket binding service. Thankfully I managed to get this to work as initialisation only, rather than running continuously.timeout 120
for each service allows the configs to generated and copied to the nginx webserver, then the scheduler and docker socket service shut down.Alternative Approaches Considered
https://github.com/hotosm/fmtm/blob/development/docs/decisions/0006-web-app-firewall.md
Notes
docker compose down -v
Review Guide
Notes for the reviewer. How to test this change?
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?