fix(backend): update project xlsform SQL after backend refactor (#1872)

* fix: update project form * remove console log * fix: refactored sql to update project form
hotosm · Nov 13, 2024 · 510dfb0 · 510dfb0
1 parent ef3193d
commit 510dfb0
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 10 deletions.
diff --git a/src/backend/app/projects/project_routes.py b/src/backend/app/projects/project_routes.py
@@ -524,7 +524,7 @@ async def generate_files(
     xlsform_upload: Annotated[
         Optional[BytesIO], Depends(central_deps.read_optional_xlsform)
     ],
-    additional_entities: list[str] = None,
+    additional_entities: Optional[list[str]] = None,
 ):
     """Generate additional content to initialise the project.
 
@@ -849,7 +849,7 @@ async def update_project_form(
     project_user_dict: Annotated[ProjectUserDict, Depends(project_manager)],
     xform_id: str = Form(...),
     category: XLSFormType = Form(...),
-) -> DbProject:
+):
     """Update the XForm data in ODK Central.
 
     Also updates the category and custom XLSForm data in the database.
@@ -876,16 +876,27 @@ async def update_project_form(
     )
 
     sql = """
-        INSERT INTO projects
-            (xlsform_content)
-        VALUES
-            (%(xls_data)s)
+        UPDATE projects
+        SET
+            xlsform_content = %(xls_data)s
+        WHERE
+            id = %(project_id)s
         RETURNING id, hashtags;
     """
     async with db.cursor() as cur:
-        await cur.execute(sql, {"xls_data": xlsform.getvalue()})
+        await cur.execute(
+            sql,
+            {
+                "xls_data": xlsform.getvalue(),
+                "project_id": project.id,
+            },
+        )
+        db.commit()
 
-    return project
+    return JSONResponse(
+        status_code=HTTPStatus.OK,
+        content={"message": f"Successfully updated the form for project {project.id}"},
+    )
 
 
 @router.get("/{project_id}/download")

diff --git a/src/frontend/src/api/CreateProjectService.ts b/src/frontend/src/api/CreateProjectService.ts
@@ -448,14 +448,14 @@ const PostFormUpdate = (url: string, projectData: Record<string, any>) => {
         formFormData.append('xlsform', projectData.upload);
 
         const postFormUpdateResponse = await axios.post(url, formFormData);
-        const resp: ProjectDetailsModel = postFormUpdateResponse.data;
+        const resp: { message: string } = postFormUpdateResponse.data;
         // dispatch(CreateProjectActions.SetIndividualProjectDetails(modifiedResponse));
         // dispatch(CreateProjectActions.SetPostFormUpdate(resp));
         dispatch(CreateProjectActions.SetPostFormUpdateLoading(false));
         dispatch(
           CommonActions.SetSnackBar({
             open: true,
-            message: 'Form Successfully Updated',
+            message: resp.message,
             variant: 'success',
             duration: 2000,
           }),