Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils/url): calculate ends with slash on every iteration #3910

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

luxass
Copy link
Contributor

@luxass luxass commented Feb 9, 2025

This fixes #3909

I don't know if this is the best way of doing this, if you can find a better/faster way let me know! :)

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.31%. Comparing base (6ceb1ab) to head (e009b25).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3910      +/-   ##
==========================================
+ Coverage   91.28%   91.31%   +0.03%     
==========================================
  Files         168      168              
  Lines       10757    10673      -84     
  Branches     3168     3046     -122     
==========================================
- Hits         9819     9746      -73     
+ Misses        937      926      -11     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe yusukebe changed the title fix: calculate ends with slash on every iteration fix(utils/url): calculate ends with slash on every iteration Feb 10, 2025
@yusukebe
Copy link
Member

Hi @luxass !

Looks good. Thank you so much!

@yusukebe yusukebe merged commit 8340a7b into honojs:main Feb 10, 2025
16 checks passed
EdamAme-x added a commit to EdamAme-x/hono that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mergePath incorrectly adds a trailing slash when first path segment is /
2 participants