-
-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jsx): improve type
(MIME) attribute types
#3305
Conversation
embed, link, object, script, source, and style elements
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3305 +/- ##
=======================================
Coverage 96.31% 96.31%
=======================================
Files 151 151
Lines 15368 15368
Branches 2671 2656 -15
=======================================
Hits 14801 14801
Misses 567 567 ☔ View full report in Codecov by Sentry. |
Nice PR. Allow me to leave comments. In my opinion, wouldn't it be better to provide only practical types in Even in |
Looks good! So how can I choose "practical types"? Just
Looks good too! I'll try it! |
Also, the type of source tag's type attribute is awesome. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Great PR, again and again! Thank you for your contribution. Merging now. |
embed, link, object, script, source, and style elements
I did NOT add BaseMime to either source, script or style element. Should I do this?
The author should do the following, if applicable
bun run format:fix && bun run lint:fix
to format the code