Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedibird merge: investigate including "circles" and scheduled posts #1154

Open
wants to merge 17 commits into
base: hometown-dev
Choose a base branch
from

Conversation

garbados
Copy link

@garbados garbados commented Feb 25, 2022

This PR merges the current state of fedibird into Hometown, adding the following features:

  • Quote posts
  • Scheduled and expiring posts
  • Emoji reacts
  • "Circles" aka groups
  • Favorite lists
  • Subscriptions
    [above was edited by Darius to reflect the direction of the conversation here]

... while preserving local-only posting.

Concerns:

  • Group directory doesn't seem to work.
  • Lots of new behaviors require documentation and UI cleanup.
  • Instances that don't support group posting default replies to followers-only.

What this PR does not do is reconcile the READMEs of each fork. I figured I would leave that for post-review cleanup, depending on what we decide to do with this.

This branch is running successfully on herd dot bovid dot space.

I submit this PR for consideration and discussion. What do you think?

@garbados
Copy link
Author

Basically there are a lot of loose ends here to tie up and it wouldn't hurt to take a day doing so. Consider this a WIP PR until then.

@dariusk dariusk added this to the v1.1.0 milestone May 8, 2022
@dariusk
Copy link

dariusk commented May 8, 2022

Tagging this for the v1.1.0 milestone because I plan to review and possibly cherry-pick individual changes.

@nevillepark
Copy link

Is this the appropriate place to weigh in on any of the possible features?

@dariusk
Copy link

dariusk commented May 9, 2022

@nevillepark Yes! Although I'm only interested in "Circles" and in scheduled posts. Everything else seems like it could have bad social side effects and needs to be talked through more.

@hughrun
Copy link

hughrun commented May 9, 2022

If "quote posts" refers to posting in response to another post with that post embedded, I would urge caution in bringing this in to HomeTown. Quote posting has been deliberately excluded from the main Mastodon project because it encourages toxic behaviours like dogpiling and spreading things out of context.

I expect toxic behaviour would be less likely in communities that have chosen HomeTown, but nevertheless I'd prefer this feature is not included, if that's what it refers to.

@dariusk dariusk changed the title Fedibird merge Fedibird merge: investigate including "circles" and scheduled posts May 9, 2022
@dariusk
Copy link

dariusk commented May 9, 2022

@hughrun I'm really only interested in Circles and scheduled posts, but that's unclear from the header so I've updated the title of this issue to reflect that.

@garbados
Copy link
Author

garbados commented May 9, 2022

I would love to include "Favorite lists" in the next release, too! It allows you to designate a list as "favorite" so that it shows up on the navbar on the mobile web UI. As I usually access fedi from my phone's browser, and because I organize most every one of my followers into exclusive lists, being able to access those lists in one click rather than three or four is huge.

@nevillepark
Copy link

@dariusk Thank you! Like @hughrun I was primarily concerned about quote posts as I feel they're too prone to enabling bad behaviour.

Scheduled/expiring posts is a great idea. As for circles/groups, something to look into is how well they play with Guppe groups. We should make sure that, say, adding a Guppe group to a circle doesn't break anything.

@dariusk
Copy link

dariusk commented May 9, 2022

Right, yes, "favorite lists" is a good one too - frankly higher on my priority list than circles as it's more straightforward.

@dariusk dariusk removed this from the v1.1.0 milestone Dec 4, 2022
@dariusk
Copy link

dariusk commented Dec 4, 2022

Moving this to backlog, it's out of scope for 1.1

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants